Skip to content

Commit

Permalink
Fix/return global value to proxy json hook (#543)
Browse files Browse the repository at this point in the history
Signed-off-by: Pavel Okhlopkov <[email protected]>
Co-authored-by: Pavel Okhlopkov <[email protected]>
  • Loading branch information
ldmonster and Pavel Okhlopkov authored Dec 11, 2024
1 parent 64e8f67 commit 95c8f23
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion pkg/module_manager/models/hooks/kind/batch_hook.go
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ func (sh *BatchHook) Execute(configVersion string, bContext []bindingcontext.Bin
sh.GetPath(),
args,
envs).
WithLogProxyHookJSON(sh.LogProxyHookJSON).
WithLogProxyHookJSON(shapp.LogProxyHookJSON).
WithLogProxyHookJSONKey(sh.LogProxyHookJSONKey).
WithLogger(sh.Logger.Named("executor"))

Expand Down
4 changes: 2 additions & 2 deletions pkg/module_manager/models/hooks/kind/shellhook.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ func (sh *ShellHook) Execute(configVersion string, bContext []bindingcontext.Bin
sh.GetPath(),
[]string{},
envs).
WithLogProxyHookJSON(sh.LogProxyHookJSON).
WithLogProxyHookJSON(shapp.LogProxyHookJSON).
WithLogProxyHookJSONKey(sh.LogProxyHookJSONKey).
WithLogger(sh.Logger.Named("executor"))

Expand Down Expand Up @@ -171,7 +171,7 @@ func (sh *ShellHook) getConfig() (configOutput []byte, err error) {
sh.Path,
args,
envs).
WithLogProxyHookJSON(sh.LogProxyHookJSON).
WithLogProxyHookJSON(shapp.LogProxyHookJSON).
WithLogProxyHookJSONKey(sh.LogProxyHookJSONKey).
WithLogger(sh.Logger.Named("executor")).
WithCMDStdout(nil)
Expand Down

0 comments on commit 95c8f23

Please sign in to comment.