Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move logging setup #423

Merged
merged 2 commits into from
Oct 30, 2023
Merged

move logging setup #423

merged 2 commits into from
Oct 30, 2023

Conversation

yalosev
Copy link
Contributor

@yalosev yalosev commented Oct 30, 2023

Overview

Move logging setup function

What this PR does / why we need it

Logging config should be set before we start to initialize any clients to avoid plain-text log lines

Special notes for your reviewer

@yalosev yalosev added enhancement New feature or request go Pull requests that update Go code labels Oct 30, 2023
@yalosev yalosev changed the title move logging to the Setup() function move logging setup Oct 30, 2023
@yalosev yalosev requested a review from nabokihms October 30, 2023 10:56
@yalosev yalosev marked this pull request as ready for review October 30, 2023 10:56
@nabokihms nabokihms merged commit 9aa956b into main Oct 30, 2023
8 checks passed
@yalosev yalosev deleted the fix-logging branch October 30, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabokihms nabokihms nabokihms approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yalosev @nabokihms