Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor module-manager #426

Merged
merged 89 commits into from
Nov 30, 2023
Merged

Refactor module-manager #426

merged 89 commits into from
Nov 30, 2023

Conversation

yalosev
Copy link
Contributor

@yalosev yalosev commented Nov 9, 2023 •
edited
Loading

Overview

Incapsulate modules:

  • BasicModule - main module for module-manager to work with. Contains:
    • hooks
    • values
    • moduleConfig
  • HelmModule - produces from BasicModule, contains:
    • helm chart
    • module values
    • global values
  • GlobalModule - ephemeral container for global hooks. Contains:
    • hooks
    • values
    • globalConfig

Add ModuleLoader as interface to have ability to replace it with the custom one
Add events to notify about changes in the modules

What this PR does / why we need it

This PR make order in the hooks structure. ModuleManager contains set of BasicModules to operate with. While they can be loaded via the custom loader

Special notes for your reviewer

@yalosev yalosev added enhancement New feature or request go Pull requests that update Go code labels Nov 9, 2023
@yalosev yalosev added the tests/run/all Run tests on full matrix of k8s versions label Nov 9, 2023
@yalosev yalosev added tests/run/all Run tests on full matrix of k8s versions and removed tests/run/all Run tests on full matrix of k8s versions labels Nov 15, 2023
@yalosev yalosev requested a review from nabokihms November 20, 2023 11:24
@yalosev yalosev marked this pull request as ready for review November 20, 2023 11:24
@yalosev yalosev removed the request for review from nabokihms November 20, 2023 12:36
@nabokihms nabokihms self-requested a review November 20, 2023 12:37
nabokihms
nabokihms reviewed Nov 22, 2023
View reviewed changes
pkg/addon-operator/bootstrap.go Outdated Show resolved Hide resolved
pkg/addon-operator/operator.go Outdated Show resolved Hide resolved
pkg/addon-operator/operator.go Show resolved Hide resolved
pkg/module_manager/models/hooks/global_hook.go Show resolved Hide resolved
pkg/module_manager/loader/fs/fs.go Show resolved Hide resolved
pkg/module_manager/models/hooks/global_hook.go Show resolved Hide resolved
pkg/module_manager/models/hooks/global_hook.go Show resolved Hide resolved
pkg/module_manager/models/hooks/module_hook.go Outdated Show resolved Hide resolved
pkg/module_manager/models/hooks/module_hook.go Show resolved Hide resolved
pkg/module_manager/models/modules/helm.go Show resolved Hide resolved
@yalosev yalosev requested a review from nabokihms November 24, 2023 10:15
@nabokihms nabokihms merged commit 29b3c1d into main Nov 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabokihms nabokihms nabokihms approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request go Pull requests that update Go code tests/run/all Run tests on full matrix of k8s versions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yalosev @nabokihms