Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vanilla os and aeon setup instructions #3700

Closed
wants to merge 1 commit into from
Closed

Add vanilla os and aeon setup instructions #3700

wants to merge 1 commit into from

Conversation

twihno
Copy link

@twihno twihno commented Aug 9, 2024

fixes #3699

@mirkobrombin @sysrich What's your opinion on this description? As mentioned in #3699 I think it would be nice to explicitly state that there is no setup needed for using flatpak/flathub in these distros.

Should it be explicitly mentioned that flathub is the preconfigured remote?

@mirkobrombin
Copy link
Contributor

mirkobrombin commented Aug 9, 2024

Speaking for Vanilla OS here. As you said, both Flatpak and Flathub are pre-configured in Vanilla OS. But I would also mention the steps to install Flathub in case something went wrong. We documented it here.

Also thanks for the PR.

Copy link
Contributor

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting Vanilla OS, LGTM after Mirko's suggestion.


If possible can you include a smaller/lighter version of our logo (will request one from @mirkobrombin) since the other distro logo image assets are much smaller and lightweight.

@razzeee
Copy link
Member

razzeee commented Aug 9, 2024

We're only syncing our instructions from https://github.com/flatpak/flatpak.github.io so please add these there for now

@razzeee razzeee closed this Aug 9, 2024
@twihno
Copy link
Author

twihno commented Aug 9, 2024

Apparently I'm unable to see the difference between flatpak/flatpak.github.io and flathub-infra/website in the build script. Will open another PR in the other repo

@razzeee
Copy link
Member

razzeee commented Aug 9, 2024

Apparently I'm unable to see the difference between flatpak/flatpak.github.io and flathub-infra/website in the build script. Will open another PR in the other repo

I'm not sure I get what you're hinting at

@twihno
Copy link
Author

twihno commented Aug 9, 2024

TL;DR: I'm stupid

I opened the build script and removed the 4 lines related to fetching the current distro yaml from the flatpak/flatpak.github.io repo

  1. because I didn't properly read the name of the git repo and thought it would be pulling the current version from flathub-infra/website
  2. i wanted to use my current changes

If I had properly read the build script I would have noticed that it wants to pull the distro config from flatpak/flatpak.github.io and that that that repo contains the "source of truth" for the setup instructions

@razzeee
Copy link
Member

razzeee commented Aug 9, 2024

FYI I want to change the source here, but will likely do that after you've landed everything. (if I even find the time)

flatpak/flatpak.github.io#674

@kbdharun
Copy link
Contributor

kbdharun commented Aug 9, 2024

FYI I want to change the source here, but will likely do that after you've landed everything. (if I even find the time)

flatpak/flatpak.github.io#674

Hi, our changes has landed upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Vanilla OS and Aeon setup instructions
4 participants