Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize navigation title for accessibility + IDs for UI automation #3803

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

bbirman
Copy link
Member

@bbirman bbirman commented Jan 14, 2025

Example of default and big below. The default is a little bolder than it was before but it actually matches the nav bar titles that we're already had on "Add Connection" and "Choose Connection".

Tested on iPhone + iPad in portrait and landscape

default big

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 62.00%. Comparing base (106df6f) to head (76d0e89).
Report is 10 commits behind head on dev.

Files with missing lines Patch % Lines
...forceSDKCore/Classes/Login/SFLoginViewController.m 0.00% 22 Missing ⚠️
...ore/Classes/Login/LoginHost/NewLoginHostView.swift 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3803      +/-   ##
==========================================
- Coverage   62.75%   62.00%   -0.75%     
==========================================
  Files         224      225       +1     
  Lines       21361    21624     +263     
==========================================
+ Hits        13405    13408       +3     
- Misses       7956     8216     +260     
Components Coverage Δ
Analytics 84.09% <ø> (ø)
Common 68.87% <ø> (+0.08%) ⬆️
Core 50.60% <2.63%> (-1.01%) ⬇️
SmartStore 73.70% <ø> (ø)
MobileSync 87.58% <ø> (ø)
Files with missing lines Coverage Δ
...ore/Classes/Login/LoginHost/NewLoginHostView.swift 0.00% <0.00%> (ø)
...forceSDKCore/Classes/Login/SFLoginViewController.m 8.96% <0.00%> (-4.20%) ⬇️

... and 3 files with indirect coverage changes

@bbirman bbirman changed the title Resize navigation title for accessibility Resize navigation title for accessibility + IDs for UI automation Jan 14, 2025
@bbirman bbirman merged commit 0a3fdf9 into forcedotcom:dev Jan 15, 2025
7 of 8 checks passed
@bbirman bbirman deleted the login-accessibility branch January 15, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants