-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript support, Demo files and separate italic theme #21
base: master
Are you sure you want to change the base?
Conversation
- Splitted themes for more italic style - Preserved original theme
Would be cool if one of you guys could review it 😄 |
Looks good to me 👍 |
@gaearon Hey Dan, any chance that we can merge this for TypeScript support? |
That would be great, is there a way to test this specific branch locally? |
@adriantoine you can clone my fork via git into your |
@tobiastimm well I ended up using your theme Raiju, thanks! |
Very nice, thank you @tobiastimm EDIT: @tobiastimm would it be possible to add a color for type assignment perhaps? For example: ids: string[] so we highlight string[] |
@GlennSmeulders sry I'm not working on this anymore :/ |
@GlennSmeulders see https://twitter.com/TbsTimm/status/1011895476231262209 . Support also available for the subliminal variant |
it would be niice |
In my last PR #5 I've added TypeScript support to subliminal.
In this PR I have done some refactoring
TypeScript before
TypeScript after
The screens are based on the
Subliminal Operator
theme. In the original theme the italic style style is kept to a minimum.Fixes #19 #4
EDIT:
TypeScript ts / tsx
HTML before
HTML after