Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role name to profile page, replace GET route handlers with functions in server components #84

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

eamansour
Copy link
Member

@eamansour eamansour commented Jan 16, 2025

Why?

Related to galasa-dev/projectmanagement#2071

Changes

  • Added simple role entry in the profile page to display the user's role in the system
  • Refactored existing pages to get data from server components rather than by sending REST API calls to an intermediate REST API existing on the webui that calls out to the Galasa API server
  • Use OpenAPI-generated models instead of creating duplicates as interfaces
  • Replaced .toLocaleDateString() and .toLocaleTimeString() calls with .toUTCString() as those calls could be inefficient (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toLocaleDateString)

…s instead of duplicates, update unit tests

Signed-off-by: Eamonn Mansour <[email protected]>
Signed-off-by: Eamonn Mansour <[email protected]>
@eamansour eamansour marked this pull request as draft January 20, 2025 13:46
@eamansour eamansour marked this pull request as ready for review January 23, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant