Fix deploy buttons

geirsagberg · Mar 12, 2023 · 52c1e72 · 52c1e72
1 parent 8123830
commit 52c1e72
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 15 deletions.
diff --git a/README.md b/README.md
@@ -24,6 +24,7 @@ To use GDC, you need a couple of things:
     - `ref`: Which release version to deploy (e.g. v1.0.3)
     - `environment`: Which environment to deploy to (e.g. dev, test or prod)
   - The workflow must create a deployment for the same commit as the release, and update status on success or failure.
+    - RECOMMENDED: If you create the deployment with the `payload` of `{"workflow_run_id": ${{ github.run_id }}}`, the deployment will be linked to the workflow run in the UI.
   - See [the GDC Deploy workflow](./.github/workflows/deploy.yml) as an example.
 
 ## Hosting

diff --git a/src/components/ReleasesTableView.tsx b/src/components/ReleasesTableView.tsx
@@ -161,6 +161,7 @@ export const ReleasesTableView = () => {
         {workflowRun && (
           <Tooltip title={`${workflowRun.name} #${workflowRun.run_number}`}>
             <IconButton
+              size="medium"
               color={
                 workflowRun.conclusion
                   ? workflowRun.conclusion === 'success'
@@ -170,7 +171,7 @@ export const ReleasesTableView = () => {
               }
               target="_blank"
               href={workflowRun.html_url}>
-              <Icon>launch</Icon>
+              <Icon fontSize="small">launch</Icon>
             </IconButton>
           </Tooltip>
         )}
@@ -189,19 +190,22 @@ export const ReleasesTableView = () => {
             <TableCell>Release name</TableCell>
             {selectedEnvironments.map((environment) => (
               <TableCell key={environment.name}>
-                <Link
-                  href={`https://github.com/${repo?.owner}/${
-                    repo?.name
-                  }/deployments/activity_log?environment=${encodeURIComponent(
-                    environment.name
-                  )}`}
-                  target="_blank"
-                  color="inherit">
-                  {environment.name}
-                </Link>
-                <IconButton onClick={() => removeEnvironment(environment.name)}>
-                  <Icon>delete</Icon>
-                </IconButton>
+                <Stack direction="row" gap={1} alignItems="center">
+                  <Link
+                    href={`https://github.com/${repo?.owner}/${
+                      repo?.name
+                    }/deployments/activity_log?environment=${encodeURIComponent(
+                      environment.name
+                    )}`}
+                    target="_blank"
+                    color="inherit">
+                    {environment.name}
+                  </Link>
+                  <IconButton
+                    onClick={() => removeEnvironment(environment.name)}>
+                    <Icon>delete</Icon>
+                  </IconButton>
+                </Stack>
               </TableCell>
             ))}
           </TableRow>

diff --git a/src/theme.ts b/src/theme.ts
@@ -15,7 +15,7 @@ export const theme = createMuiTheme({
     MuiDialogContent: {
       styleOverrides: {
         root: {
-          paddingTop: '0.5rem !important',
+          paddingTop: '1rem !important',
         },
       },
     },