Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle reference creation with unit file containing both T and N #361

Merged
merged 6 commits into from
Nov 3, 2023

Conversation

Smeds
Copy link
Collaborator

@Smeds Smeds commented Nov 3, 2023

This PR:

(If this is a release PR, no need to add following. Leave this part empty)
(Use the following lines to create a PR text body. Make sure to remove all non-relevant one after you're done)
(Repeat each field as many times as necessary)

Added: for new features.
Changed: for changes in existing functionality.
Deprecated: for soon-to-be removed features.
Removed: for now removed features.
Fixed: for any bug fixes.
Security: in case of vulnerabilities.

Review and tests:

  • Tests pass
  • If you've fixed a bug or added code that should be tested, add tests!
  • Code review
  • CHANGELOG.md is updated
  • New code is executed and covered by tests, and test approve

@Smeds Smeds requested a review from jonca79 as a code owner November 3, 2023 12:44
@Smeds Smeds marked this pull request as draft November 3, 2023 12:44
@Smeds Smeds marked this pull request as ready for review November 3, 2023 14:19
@Smeds Smeds merged commit cf7a954 into develop Nov 3, 2023
7 checks passed
@Smeds Smeds deleted the Smeds-patch-2 branch November 3, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants