Skip to content

Commit

Permalink
Fix Invalid image tag "latest" warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
@starfreck
starfreck committed Dec 13, 2024
1 parent 6ceb11c commit 0ccae4f
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 16 deletions.
0 ente-photos/data/cli-data/.gitkeep → ente-photos/data/.gitkeep
View file
File renamed without changes.
Empty file removed ente-photos/data/custom-logs/.gitkeep
View file
Empty file.
Empty file removed ente-photos/data/minio-data/.gitkeep
View file
Empty file.
Empty file removed ente-photos/data/postgres-data/.gitkeep
View file
Empty file.
15 changes: 4 additions & 11 deletions ente-photos/docker-compose.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ services:
museum:
# https://github.com/ente-io/ente/pkgs/container/server
image: ghcr.io/ente-io/server:b0674cd5f37cebda0f446db7ce1e87a3e6d8b9fc@sha256:d44049492bb62a3c0c64126ade1b2c0294683422e5a1b7d656d128186919b5e9

Check failure on line 52 in ente-photos/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Invalid image name "ghcr.io/ente-io/server:b0674cd5f37cebda0f446db7ce1e87a3e6d8b9fc@sha256:d44049492bb62a3c0c64126ade1b2c0294683422e5a1b7d656d128186919b5e9" 

Error: HTTP 404 for ghcr.io/ente-io/server:b0674cd5f37cebda0f446db7ce1e87a3e6d8b9fc@sha256:d44049492bb62a3c0c64126ade1b2c0294683422e5a1b7d656d128186919b5e9: <!doctype html>
<html lang="en">

<head>
    <meta charset="utf-8">
    <title>404 : Docker</title>
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <style>
    * {
        line-height: 1.2;
        margin: 0;
    }

    html {
        color: #71859d;
        display: table;
        height: 100%;
        text-align: center;
        width: 100%;
    }

    body {
        background: #fff;
        display: table-cell;
        font-family: "HelveticaNeue-Light", "Helvetica Neue Light", "Helvetica Neue", Helvetica, Arial, "Lucida Grande", sans-serif;
        font-weight: 300;
        margin: 2em auto;
        vertical-align: middle;
    }

    a {
        color: #22b8eb;
        text-decoration: none;
    }


    @media only screen and (max-width: 280px) {
        body,
        p {
            width: 95%;
        }
    }

    #message {
        font-size: 21px;
        text-align: center;
        animation: fadein 2s;
        -moz-animation: fadein 2s;
        /* Firefox */
        -webkit-animation: fadein 2s;
        /* Safari and Chrome */
        -o-animation: fadein 2s;
        /* Opera */
    }

    @Keyframes fadein {
        from {
            opacity: 0;
        }
        to {
            opacity: 1;
        }
    }

    @-moz-keyframes fadein {
        /* Firefox */
        from {
            opacity: 0;
        }
        to {
            opacity: 1;
        }
    }

    @-webkit-keyframes fadein {
        /* Safari and Chrome */
        from {
            opacity: 0;
        }
        to {
            opacity: 1;
        }
    }

    @-o-keyframes fadein {
        /* Opera */
        from {
            opacity: 0;
        }
        to {
            opacity: 1;
        }
    }

    </style>
</head>
<body>
    <div id="message">
      <img  src=" data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAkYAAAJGCAYAAAC+3UpsAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAyhpVFh0WE1MOmNvbS5hZG9iZS54bXAAAAAAADw/eHBhY2tldCBiZWdpbj0i77u/IiBpZD0iVzVNME1wQ2VoaUh6cmVTek5UY3prYzlkIj8+IDx4OnhtcG1ldGEgeG1sbnM6eD0iYWRvYmU6bnM6bWV0YS8iIHg6eG1wdGs9IkFkb2JlIFhNUCBDb3JlIDUuNi1jMDY3IDc5LjE1Nzc0NywgMjAxNS8wMy8zMC0yMzo0MDo0MiAgICAgICAgIj4gPHJkZjpSREYgeG1sbnM6cmRmPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5LzAyLzIyLXJkZi1zeW50YXgtbnMjIj4gPHJkZjpEZXNjcmlwdGlvbiByZGY6YWJvdXQ9IiIgeG1sbnM6eG1wPSJodHRwOi8vbnMuYWRvYmUuY29tL3hhcC8xLjAvIiB4bWxuczp4bXBNTT0iaHR0cDovL25zLmFkb2JlLmNvbS94YXAvMS4wL21tLyIgeG1sbnM6c3RSZWY9Imh0dHA6Ly9ucy5hZG9iZS5jb20veGFwLzEuMC9zVHlwZS9SZXNvdXJjZVJlZiMiIHhtcDpDcmVhdG9yVG9vbD0iQWRvYmUgUGhvdG9zaG9wIENDIDIwMTUgKE1hY2ludG9zaCkiIHhtcE1NOkluc3RhbmNlSUQ9InhtcC5paWQ6Nzg1NjVCQzREMzZFMTFFNTlCRTg4MzY3QzAxNzVDRUUiIHhtcE1NOkRvY3VtZW50SUQ9InhtcC5kaWQ6Nzg1NjVCQzVEMzZFMTFFNTlCRTg4MzY3QzAxNzVDRUUiPiA8eG1wTU06RGVyaXZlZEZyb20gc3RSZWY6aW5zdGFuY2VJRD0ieG1wLmlpZDo3ODU2NUJDMkQzNkUxMUU1OUJFODgzNjdDMDE3NUNFRSIgc3RSZWY6ZG9jdW1lbnRJRD0ieG1wLmRpZDo3ODU2NUJDM0QzNkUxMUU1OUJFODgzNjdDMDE3NUNFRSIvPiA8L3JkZjpEZXNjcmlwdGlvbj4gPC9yZGY6UkRGPiA8L3g6eG1wbWV0YT4gPD94cGFja2V0IGVuZD0iciI/Pn5rcOoAAFy2SURBVHja7N0HfBzlnf/xn8qutFpZcu8YjA3YxvQeSoAECAGOS4OE9F4vyT/ln7vc5VLvcrnk7tKTCyl3/yRcEtI4TAuhBEjoxjQ33HGXm2StVta2/+83O2OvVitpV9o6+3m/eBhZ2jLzzOw8333mmZkGAYBR9ESijTqZ5pbJWiZmlElZ/w5oadfSpiWY8btwxkt25vnW3Rk/R7TEtBzQMqClT0tvxu+8sj/r3/u0dFnpCIeSrE0AI2mgCoC6DzwztczTcpQ7na1llpap7nS6+3NjjS+uhaI9WnZr2eH+bNPtWrZoedGd7iRAAQQjAP4NP1N0cpyWBVoWuuUYNwjN0dJMLQ0S17LNDUqbtKxzy3otL2ho2ksVAQQjANUdfprdwLNEy1Iti7Ucr+VYSR/KQvHY4bkNWtZqWaXlOS0rLTxpaIpTPQDBCEB5Q9BcnZyu5RQtJ7phaJGkx/Ggcmys02o3JD2v5WktyzUsbaVqAIIRgPEHIPt8nqDlVC2nuWHIfp5K7dQUG8u0wkKSlqfcn9doYEpRNQDBCMDwQcjGAp2t5Vy32M8cBvMnOxz3mJZH3PIYY5cAghFQ70HIDn9d6BYLQsdRK3XtBTckPWhFg9JqqgQgGAF+DUF2qruNBbpYy0VumUHNYAS7tDzglvu1rOQyAgDBCKjlMDRfJ5e55WWSvhAiMFZ24cp7tNxtRUPSRqoEIBgB1RyE7GrOl2aEoYXUCkponReStNyrQambKgEIRkClw5CNE7pGy1VaLtDSRK2gAhJaHtJym5ZbGZ8EEIyAcgUhu/eXjQ+62g1Ex1IrqEJ2AcpbtSzT8oAGpQGqBCAYAcUKQyGdvFLLq91A1EGtoJY2YTcg/VbL7RqSolQJQDACCg1DEyR9eOx1Wq6QwXeGB2pVRMtdWm7Wcpu
user: "1000:1000"
depends_on:
postgres:
condition: service_healthy
Expand Down Expand Up @@ -81,13 +80,11 @@ services:
volumes:

Check notice on line 80 in ente-photos/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Mounted file/directory "/ente-photos/data/custom-logs" doesn't exist 

The volume "${APP_DATA_DIR}/data/custom-logs:/var/logs" tries to mount the file/directory "/ente-photos/data/custom-logs", but it is not present. This can lead to permission errors!

Check notice on line 80 in ente-photos/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Mounted file/directory "/ente-photos/museum.yaml" doesn't exist 

The volume "${APP_DATA_DIR}/museum.yaml:/museum.yaml:ro" tries to mount the file/directory "/ente-photos/museum.yaml", but it is not present. This can lead to permission errors!
- ${APP_DATA_DIR}/data/custom-logs:/var/logs
- ${APP_DATA_DIR}/museum.yaml:/museum.yaml:ro
- ${APP_DATA_DIR}/scripts/compose/credentials.yaml:/credentials.yaml:ro
- ${APP_DATA_DIR}/data:/data:ro
restart: on-failure

cli:
image: vasuratanpara/ente-cli:latest@sha256:2a140ecae2671cb845e43f20f9c765e0f3ba1c00f54c022a42841f4bba9f51ce
user: "1000:1000"
image: vasuratanpara/ente-cli:v0.2.2@sha256:027abc99f012a910a28289034266ce4a63aeb1484c65d56b3743056f0795a3af
depends_on:
- museum
environment:
Expand All @@ -98,16 +95,14 @@ services:
restart: on-failure

socat:
image: alpine/socat:latest@sha256:d6cc968aacbfab4437bea9fb2df6d3719b6d0edec4cb59f46a6bd33ad7b0f7be
user: "1000:1000"
image: alpine/socat:1.8.0.0@sha256:a6be4c0262b339c53ddad723cdd178a1a13271e1137c65e27f90a08c16de02b8
network_mode: service:museum
depends_on:
- museum
command: "TCP-LISTEN:${MINIO_API_PORT},fork,reuseaddr TCP:minio:${MINIO_API_PORT}"

postgres:
image: postgres:15@sha256:6cbdd616ae7ea61fa88873fdab529b3fd141b8a8311bfe4e6e62575f643f88fe
user: "1000:1000"
ports:

Check notice on line 106 in ente-photos/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

External port mapping "${DB_PORT}:${DB_PORT}" 

Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
- "${DB_PORT}:${DB_PORT}"
environment:
Expand All @@ -126,8 +121,7 @@ services:
restart: on-failure

minio:
image: minio/minio:latest@sha256:ac591851803a79aee64bc37f66d77c56b0a4b6e12d9e5356380f4105510f2332
user: "1000:1000"
image: minio/minio:RELEASE.2024-11-07T00-52-20Z@sha256:ac591851803a79aee64bc37f66d77c56b0a4b6e12d9e5356380f4105510f2332
# Use different ports than the minio defaults to avoid conflicting
# with the ports used by Prometheus.
ports:

Check notice on line 127 in ente-photos/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

External port mapping "${MINIO_API_PORT}:${MINIO_API_PORT}" 

Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).

Check notice on line 127 in ente-photos/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

External port mapping "${MINIO_CONSOLE_PORT}:${MINIO_CONSOLE_PORT}" 

Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
Expand All @@ -141,8 +135,7 @@ services:
restart: on-failure

minio-provision:
image: minio/mc:latest@sha256:8f94d208188dcd04bbaa51b54578bb43ea2a663626ca59889c07d4fb8ae9546d
user: "1000:1000"
image: minio/mc:RELEASE.2024-11-17T19-35-25Z@sha256:8f94d208188dcd04bbaa51b54578bb43ea2a663626ca59889c07d4fb8ae9546d
depends_on:
- minio
environment:
Expand Down
13 changes: 8 additions & 5 deletions ente-photos/exports.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,15 @@ export MINIO_ROOT_PASSWORD="testtest"
export MINIO_REGION="eu-central-2"

# SMTP Configs to send OTP emails
export SMTP_HOST="smtp.gmail.com"
export SMTP_PORT="465"
export SMTP_USERNAME="[email protected]"
export SMTP_PASSWORD="changeme"
# Notes:
# - Make sure they are correct since the program will stuck at signup if there is any issue
# - Gmail SMTP hast might fail due to timeout errors, check your latency via ping
# export SMTP_HOST="smtp.gmail.com"
# export SMTP_PORT="465"
# export SMTP_USERNAME="[email protected]"
# export SMTP_PASSWORD="changeme"
# The email address from which to send the email.
export SMTP_EMAIL="[email protected]"
# export SMTP_EMAIL="[email protected]"

# Uncomment and set these to your email ID or domain to avoid checking server logs for OTPs.
# export INTERNAL_HARDCODED_OTT_EMAILS="[email protected],123456"
Expand Down
4 changes: 4 additions & 0 deletions ente-photos/umbrel-app.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ website: https://ente.io
repo: https://github.com/ente-io/ente
support: https://ente.io/community
port: 8080
gallery:

Check warning on line 31 in ente-photos/umbrel-app.yml

View workflow job for this annotation

GitHub Actions / Lint apps

"icon" and "gallery" needs to be empty for new app submissions 

The "icon" and "gallery" fields must be empty for new app submissions as it is being created by the Umbrel team.
- 1.jpg
- 2.jpg
- 3.jpg
releaseNotes: ""
path: ""
defaultUsername: ""
Expand Down

0 comments on commit 0ccae4f

Please sign in to comment.