-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Submission: WordPress #1947
base: master
Are you sure you want to change the base?
Conversation
Excellent, thanks for yet another app submission @al-lac! We'll start on gallery assets. This looks really good. Here's one consideration:
Ah yes, here's some extra info on that: One option here that could be worth testing is:
It's possible though that this doesn't do everything we need. |
Hey @nmfretz! Yeah that could also make sense. But as the admin dashboard is running on the same port, I don't think you can protect it that way. Probably with a special reverse proxy config though. Whatever you think would be for the best here! |
@al-lac, ah yes you're right. Re-reading my comment I'm not sure what I was talking about regarding exposing the public site but not the dashboard... sorry about that. So essentially our two options are:
In this configuration a user could tunnel or point a reverse proxy to the host at port 8567 or they could also choose to point to the
In this configuration, you wouldn't be able to point to the host at port 8567 because of the Right now, the precedent is that we are always using the app proxy container unless an app needs to run in host networking mode. Since WordPress does not need host networking mode, I don't think that we should break that precedent. Let's place this behind the app proxy container for the initial release. We can then gauge the reaction to it and make a decision on whether the proxy should be removed. I'll make the required changes and include some instructions in the app descriptions and then we can test. |
@al-lac - could you please give this a test with the recent changes and let me know what you think? It's important that we don't reduce the functionality of the app needlessly so please let me know if I have accidentally done so and we can revert. I have added the app proxy and have also added |
Hey @nmfretz! Everything seems to work fine, also really nice that you direct users towards the admin page! Was able to get the reverse proxy working by entering The only thing that the app_proxy limits, is that you cannot use a proxy that is running on a different umbrel or other system. But I am not sure how many users would take advantage of this. |
App Submission
WordPress
256x256 SVG icon
https://en.m.wikipedia.org/wiki/File:WordPress_blue_logo.svg
Gallery images
I have tested my app on:
Notes
Port mapping needed as the app_proxy seems to remove headers set by nginx or other proxies.