Jupyter Frame Selector component #1738
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annehaley
force-pushed
the
jupyter-frame-selector
branch
2 times, most recently
from
ed08d58 to
ba22d9c
Compare
annehaley
force-pushed
the
jupyter-frame-selector
branch
2 times, most recently
from
ccc83cb to
fd41910
Compare
annehaley
force-pushed
the
jupyter-frame-selector
branch
2 times, most recently
from
aa6bca8 to
b9a13d9
Compare
annehaley
force-pushed
the
jupyter-frame-selector
branch
2 times, most recently
from
cfd5191 to
6d65b1f
Compare
annehaley
force-pushed
the
jupyter-frame-selector
branch
from
6d65b1f to
51783f3
Compare
annehaley
force-pushed
the
jupyter-frame-selector
branch
from
d3377c5 to
dadab11
Compare
annehaley
force-pushed
the
jupyter-frame-selector
branch
from
dadab11 to
82dcb36
Compare
manthey
reviewed
Jan 16, 2025
annehaley
force-pushed
the
jupyter-frame-selector
branch
from
9d4705a to
724c7f9
Compare
manthey
reviewed
Jan 21, 2025
large_image/tilesource/jupyter.py
Outdated
| def get_frame_histogram(self, query): | ||
| if self._layer is not None: | ||
| frame = query.get('frame') | ||
| frame_histograms = self.frame_selector.frameHistograms or {} |
There was a problem hiding this comment.
Why do you copy this and modify the copy? If there are concurrent histogram requests, won't this end up just keeping the last one?
There was a problem hiding this comment.
The copy is done so that we set self.frame_selector.frame_histograms to a new object to trigger the Vue watcher that detects changes to that object. Without the copy statement, only the first histogram will be shown and Vue cannot detect subsequent updates. I haven't encountered a case where concurrent requests overwrite one another, but maybe some extra bookkeeping on this class could resolve that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves and refactors the component files for the Frame Selector such that the widget can be used in the Girder/Backbone context as well as the Jupyter context, using the same source code.
frame_selector.mp4