Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't hide app updater pop-up entirely in flatpak package #6039

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: don't hide app updater pop-up entirely in flatpak package #6039

wants to merge 1 commit into from
+50 −38

Conversation

ndom91
Copy link
Contributor

@ndom91 ndom91 commented Jan 21, 2025

🧢 Changes

  • After talking with Kiril, we decided that in the flatpak we should still show the update notification, even if flatpak users cant use our in-app updater. This way they're at least more quickly aware of new releases and are less likely to be stuck on an old release.
  • Note to self: update VITE_FLATPAK_ID env var in flatpak build script to PUBLIC_FLATPAK_ID

☕️ Reasoning

@vercel Vercel
Copy link

vercel bot commented Jan 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 4:26pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
gitbutler-web ⬜️ Skipped (Inspect) Jan 22, 2025 4:26pm

@vercel vercel bot temporarily deployed to Preview – gitbutler-web January 21, 2025 21:22 Inactive
@ndom91 ndom91 force-pushed the fix-test-alternative-appupdater-disable branch from 3fdd46e to 0bfb666 Compare January 21, 2025 21:22
@vercel vercel bot temporarily deployed to Preview – gitbutler-web January 21, 2025 21:23 Inactive
@ndom91 ndom91 force-pushed the fix-test-alternative-appupdater-disable branch from 0bfb666 to 86ee5e2 Compare January 21, 2025 21:29
@vercel vercel bot temporarily deployed to Preview – gitbutler-web January 21, 2025 21:29 Inactive
@ndom91 ndom91 force-pushed the fix-test-alternative-appupdater-disable branch from 86ee5e2 to 8cf5b43 Compare January 21, 2025 21:29
@vercel vercel bot temporarily deployed to Preview – gitbutler-web January 21, 2025 21:29 Inactive
@ndom91 ndom91 enabled auto-merge (rebase) January 21, 2025 21:32
@ndom91 ndom91 force-pushed the fix-test-alternative-appupdater-disable branch from 8cf5b43 to c463901 Compare January 22, 2025 11:02
@vercel vercel bot temporarily deployed to Preview – gitbutler-web January 22, 2025 11:02 Inactive
@ndom91 ndom91 force-pushed the fix-test-alternative-appupdater-disable branch from c463901 to a65e2e4 Compare January 22, 2025 11:53
@vercel vercel bot temporarily deployed to Preview – gitbutler-web January 22, 2025 11:54 Inactive
@ndom91 ndom91 force-pushed the fix-test-alternative-appupdater-disable branch from a65e2e4 to 77debef Compare January 22, 2025 14:57
@vercel vercel bot temporarily deployed to Preview – gitbutler-web January 22, 2025 14:57 Inactive
@ndom91 ndom91 force-pushed the fix-test-alternative-appupdater-disable branch from 77debef to cce86d4 Compare January 22, 2025 15:37
@vercel vercel bot temporarily deployed to Preview – gitbutler-web January 22, 2025 15:37 Inactive
@ndom91 ndom91 force-pushed the fix-test-alternative-appupdater-disable branch from cce86d4 to 78a3c56 Compare January 22, 2025 16:25
@vercel vercel bot temporarily deployed to Preview – gitbutler-web January 22, 2025 16:25 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
@gitbutler/desktop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ndom91