Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(metrics): include route specific queue length #1237

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Jan 8, 2025

Helpful info for installations with multiple queue routes

@ecrupper ecrupper requested a review from a team as a code owner January 8, 2025 19:57
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 26.31579% with 14 lines in your changes missing coverage. Please review.

Project coverage is 56.56%. Comparing base (355199f) to head (25a76d8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
api/metrics.go 0.00% 11 Missing ⚠️
queue/redis/route_length.go 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1237      +/-   ##
==========================================
- Coverage   56.57%   56.56%   -0.01%     
==========================================
  Files         628      629       +1     
  Lines       35596    35609      +13     
==========================================
+ Hits        20139    20144       +5     
- Misses      14777    14784       +7     
- Partials      680      681       +1     
Files with missing lines Coverage Δ
queue/redis/route_length.go 62.50% <62.50%> (ø)
api/metrics.go 0.00% <0.00%> (ø)

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 57815f7 into main Jan 9, 2025
11 of 13 checks passed
@ecrupper ecrupper deleted the queue-route-metrics branch January 9, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants