Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enabling a delete event to be allowed #342

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Conversation

claire1618
Copy link
Contributor

Goes along with this PR: #340

Adding a last piece to enable delete events.

@claire1618 claire1618 requested a review from a team as a code owner January 15, 2024 21:23
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (0d0e223) 95.85% compared to head (09b9075) 95.80%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
- Coverage   95.85%   95.80%   -0.06%     
==========================================
  Files          70       70              
  Lines        7504     7508       +4     
==========================================
  Hits         7193     7193              
- Misses        233      237       +4     
  Partials       78       78              
Files Coverage Δ
library/events.go 80.50% <0.00%> (-2.08%) ⬇️

@claire1618 claire1618 merged commit 483bff0 into main Jan 15, 2024
10 checks passed
@claire1618 claire1618 deleted the feat/deleteEvent3 branch January 15, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants