Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: title validator handle no parentheses + enforce whitespace #347

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

ecrupper
Copy link
Contributor

According to our docs, we should accept both formats:

Scope:

  • feat(scope): cool thing

No Scope:

  • feat: scope-less cool thing

@ecrupper ecrupper requested a review from a team as a code owner January 17, 2024 19:24
@ecrupper ecrupper changed the title fix(ci): title validator handle no parentheses + enforce whitespace fix: title validator handle no parentheses + enforce whitespace Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f40578e) 96.58% compared to head (9acee6b) 96.58%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #347   +/-   ##
=======================================
  Coverage   96.58%   96.58%           
=======================================
  Files          70       70           
  Lines        7494     7494           
=======================================
  Hits         7238     7238           
  Misses        185      185           
  Partials       71       71           

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 8a6ef2d into main Jan 17, 2024
13 checks passed
@ecrupper ecrupper deleted the fix/pr-title-validator branch January 17, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants