feat: remodling EventDelete to resemble EventTag #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
==========================================
- Coverage 96.58% 96.45% -0.13%
==========================================
Files 70 69 -1
Lines 7494 7476 -18
==========================================
- Hits 7238 7211 -27
- Misses 185 193 +8
- Partials 71 72 +1
|
wass3rw3rk
requested changes
Jan 19, 2024
wass3rw3rk
requested changes
Jan 19, 2024
added 3 commits
January 19, 2024 15:02
wass3rw3rk
requested changes
Jan 19, 2024
wass3rw3rk
approved these changes
Jan 22, 2024
ecrupper
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time a tag or branch are deleted in GitHub, both a delete and push webhook are sent out. Previously I used the delete webhook and had EventDelete modeled off of EventPush, EventPR, EventDeploy, and EventComment in how they are their own event not related to the others. However, the push webhook that is sent out with the delete webhook contains more relevant information that can solve some of the issues that were found with only having the delete webhook data (such as missing a commit and not being able to properly set the BUILD_TAG environment variable).
Therefore, EventDelete has been lumped in with push events, in the same way that EventTag has been.