-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #94479 from juanjp600/opt-in-path-rotation-tangent…
…-fix Add flag to enable use of accurate path tangents for polygon rotation in `CSGPolygon3D`
- Loading branch information
Showing
4 changed files
with
179 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| /**************************************************************************/ | ||
| /* test_csg.h */ | ||
| /**************************************************************************/ | ||
| /* This file is part of: */ | ||
| /* GODOT ENGINE */ | ||
| /* https://godotengine.org */ | ||
| /**************************************************************************/ | ||
| /* Copyright (c) 2014-present Godot Engine contributors (see AUTHORS.md). */ | ||
| /* Copyright (c) 2007-2014 Juan Linietsky, Ariel Manzur. */ | ||
| /* */ | ||
| /* Permission is hereby granted, free of charge, to any person obtaining */ | ||
| /* a copy of this software and associated documentation files (the */ | ||
| /* "Software"), to deal in the Software without restriction, including */ | ||
| /* without limitation the rights to use, copy, modify, merge, publish, */ | ||
| /* distribute, sublicense, and/or sell copies of the Software, and to */ | ||
| /* permit persons to whom the Software is furnished to do so, subject to */ | ||
| /* the following conditions: */ | ||
| /* */ | ||
| /* The above copyright notice and this permission notice shall be */ | ||
| /* included in all copies or substantial portions of the Software. */ | ||
| /* */ | ||
| /* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, */ | ||
| /* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF */ | ||
| /* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. */ | ||
| /* IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY */ | ||
| /* CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, */ | ||
| /* TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE */ | ||
| /* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */ | ||
| /**************************************************************************/ | ||
|
|
||
| #ifndef TEST_CSG_H | ||
| #define TEST_CSG_H | ||
|
|
||
| #include "../csg.h" | ||
| #include "../csg_shape.h" | ||
|
|
||
| #include "tests/test_macros.h" | ||
|
|
||
| namespace TestCSG { | ||
|
|
||
| TEST_CASE("[SceneTree][CSG] CSGPolygon3D") { | ||
| SUBCASE("[SceneTree][CSG] CSGPolygon3D: using accurate path tangent for polygon rotation") { | ||
| const float polygon_radius = 10.0f; | ||
|
|
||
| const Vector3 expected_min_bounds = Vector3(-polygon_radius, -polygon_radius, 0); | ||
| const Vector3 expected_max_bounds = Vector3(100 + polygon_radius, polygon_radius, 100); | ||
| const AABB expected_aabb = AABB(expected_min_bounds, expected_max_bounds - expected_min_bounds); | ||
|
|
||
| Ref<Curve3D> curve; | ||
| curve.instantiate(); | ||
| curve->add_point( | ||
| // p_position | ||
| Vector3(0, 0, 0), | ||
| // p_in | ||
| Vector3(), | ||
| // p_out | ||
| Vector3(0, 0, 60)); | ||
| curve->add_point( | ||
| // p_position | ||
| Vector3(100, 0, 100), | ||
| // p_in | ||
| Vector3(0, 0, -60), | ||
| // p_out | ||
| Vector3()); | ||
|
|
||
| Path3D *path = memnew(Path3D); | ||
| path->set_curve(curve); | ||
|
|
||
| CSGPolygon3D *csg_polygon_3d = memnew(CSGPolygon3D); | ||
| SceneTree::get_singleton()->get_root()->add_child(csg_polygon_3d); | ||
|
|
||
| csg_polygon_3d->add_child(path); | ||
| csg_polygon_3d->set_path_node(csg_polygon_3d->get_path_to(path)); | ||
| csg_polygon_3d->set_mode(CSGPolygon3D::Mode::MODE_PATH); | ||
|
|
||
| PackedVector2Array polygon; | ||
| polygon.append(Vector2(-polygon_radius, 0)); | ||
| polygon.append(Vector2(0, polygon_radius)); | ||
| polygon.append(Vector2(polygon_radius, 0)); | ||
| polygon.append(Vector2(0, -polygon_radius)); | ||
| csg_polygon_3d->set_polygon(polygon); | ||
|
|
||
| csg_polygon_3d->set_path_rotation(CSGPolygon3D::PathRotation::PATH_ROTATION_PATH); | ||
| csg_polygon_3d->set_path_rotation_accurate(true); | ||
|
|
||
| // Minimize the number of extrusions. | ||
| // This decreases the number of samples taken from the curve. | ||
| // Having fewer samples increases the inaccuracy of the line between samples as an approximation of the tangent of the curve. | ||
| // With correct polygon orientation, the bounding box for the given curve should be independent of the number of extrusions. | ||
| csg_polygon_3d->set_path_interval_type(CSGPolygon3D::PathIntervalType::PATH_INTERVAL_DISTANCE); | ||
| csg_polygon_3d->set_path_interval(1000.0f); | ||
|
|
||
| // Call get_brush_faces to force the bounding box to update. | ||
| csg_polygon_3d->get_brush_faces(); | ||
|
|
||
| CHECK(csg_polygon_3d->get_aabb().is_equal_approx(expected_aabb)); | ||
|
|
||
| // Perform the bounding box check again with a greater number of extrusions. | ||
| csg_polygon_3d->set_path_interval(1.0f); | ||
| csg_polygon_3d->get_brush_faces(); | ||
|
|
||
| CHECK(csg_polygon_3d->get_aabb().is_equal_approx(expected_aabb)); | ||
|
|
||
| csg_polygon_3d->remove_child(path); | ||
| SceneTree::get_singleton()->get_root()->remove_child(csg_polygon_3d); | ||
|
|
||
| memdelete(csg_polygon_3d); | ||
| memdelete(path); | ||
| } | ||
| } | ||
|
|
||
| } // namespace TestCSG | ||
|
|
||
| #endif // TEST_CSG_H |