ItemList - fix text_overrun_behavior
#101899
Open
+28
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havi05
force-pushed
the
itemlist-fix-textoverrun
branch
3 times, most recently
from
f9b47e4 to
287de4b
Compare
AThousandShips
changed the title
text_overrun_behaviorItemList - fix text_overrun_behavior
AThousandShips
added
bug
topic:gui
cherrypick:4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100810 and fixes #74486
This pr also fixes the bug that item texts aren't rendered in rtl layout direction. (wasn't reported yet)
I removed an unnecessary addition and subtraction (line 1604 and line 1629).
I have changed the text offset when using
icon_mode TOPso that the text is off center, but remains visible when using a small width.Videos
icon_mode = Top:
2025-01-21.23-01-25.mp4
icon_mode = Left:
2025-01-22.09-31-47.mp4