Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split encoding functions to expose integer encoding for tests #672

Open
drinckes opened this issue Jan 9, 2025 · 0 comments · May be fixed by #677
Open

Split encoding functions to expose integer encoding for tests #672

drinckes opened this issue Jan 9, 2025 · 0 comments · May be fixed by #677

Comments

@drinckes
Copy link
Contributor

drinckes commented Jan 9, 2025

The encoding function takes two floats (latitude and longitude), converts to integers and then does the encoding. Due to language, platform and/or os implementations, the initial conversion from float to integer can differ slightly.

To enable consistent tests, we want to make the integer encoding a separate function that can be called by the tests.

It should be called something like encodeIntegers, and take as arguments the latitude multiplied by 2.5e7 and longitude multiplied by 8.192e6 (the precision of the longest permissable codes).

This needs to be done for each implementation.

@drinckes drinckes linked a pull request Jan 10, 2025 that will close this issue
@drinckes drinckes linked a pull request Jan 10, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant