Split encoding into floating and integer functions #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've verified the conversions of the coordinates in the CSV file to the changed generated codes, and the new codes look correct. I'm going to update them - this will break all other implementations until I get around to them one by one. |
|
@bocops @fulldecent @rsramek would appreciate if you could take a look at the change please, my C isn't that hot. |
fulldecent
reviewed
Jan 16, 2025
| while (lng < 0) { | ||
| lng += 2 * OLC_kLonMaxDegrees * kGridLonPrecisionInverse; | ||
| } | ||
| while (lng >= 2 * OLC_kLonMaxDegrees * kGridLonPrecisionInverse) { |
There was a problem hiding this comment.
This while loop is a DDOS security vulnerability with large input numbers.
fulldecent
suggested changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #672
This splits the C encoding function into a public function that takes doubles, and one that takes integers.
It explicitly rounds multiplying the degrees by the precision. This will cause a small number of encoding tests to require correcting the codes.
The issue was that the C code:
and
didn't always produce the same result. In the first, it truncates the value of
degrees * precision, in the second it appears to (mostly) round it before adding it.