-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First working port to Rollup #499
Conversation
How are tests coming along? |
What kind of size savings is there, if any? |
34kb for For the tests, how are they doing in this repo? |
Okay, I added a plugin to remove comments. While most tests pass, there are some that don't, mostly ones that involve the I also added a stub |
I'll start looking at those next. |
This is still a priority, but the library has been moving along. Is there anyway you can uograde to handle conflicts? |
I'm working on it. This would have been much, much, much easier if you had merged my commits first before the others. I'm basically having to redo the entire thing all over again. Please no more commits until I finish this. Edit 1: Okay, it looks like most test-related stuff can be merged pretty easily. How many actual feature related changes there? I think it would be easier to keep my versions and then re-add the feature-related changes once merged. |
FINALLY! I have FINALLY upgraded to merge all the most recent changes! I still had to remove the functions in |
You mention in here possibly using something other than qunit, I'm VERY open to using something else, as I want code coverage in GPU.js, and qunit doesn't easily offer it. Which of the browser AND node based testing frameworks are you familiar with that allow for easily searching and running individual tests as well as all as a whole? |
Fine work. I'll take it from here. |
I pretty big issue I see so far is that we need unit tests to run in BOTH node and browser. You've changed all the unit tests to run what it seems, just in the browser. |
Unit tests are ran in node via |
As I suspected, if I change the path so I can test in node:
|
It looks like https://mochajs.org paired with https://www.npmjs.com/package/mochawesome may be a good alternative. |
I'm going to go ahead and merge some things into master, and backwards into this branch, to keep progress. Can you look into getting node unit tests running? If we need to change test runner tools, and it requires a bunch of work, we can easily build a translation tool to do it for us like this: https://gist.github.com/robertleeplummerjr/95c725d1984a1584c4db3344d1da8c39 |
I went ahead and reverted the merge into develop for the time being. It was a force push. |
I opened #525 to continue the initial PR. We can continue conversation there. |
I got my first working port to Rollup ready. Gulp has been completely removed and is no longer necessary.
Some advantages include:
dist
folder could be added to.gitignore
now. NPM automatically runsnpm run build
, so those files will be built anyway.That being said, there are some things to look out for:
Plenty of other changes were necessary. I recommend a thorough review & testing before merging.