Use null rather than empty string for unspecified namespace #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible for (arguably misformed) package metadata to have the empty string as the namespace. This can happen for example when ingesting an OCI image that does not have the correct repository URL specified. Currently guac-visualiser does not let you pick beyond a namespace that is the empty string: it would not make the "package name" dropdown sensitive (although it would correctly populate the options from the GraphQL response). This commit updates the "empty" state for the package name option from the empty string to null (like is used for version). Then update the `disabled` param to be determined on whether the namespace is null (rather than the empty string). Signed-off-by: Ed Baunton <[email protected]>
edbaunton
force-pushed
the
edbaunton/empty-namespace
branch
from
418bd12 to
e0a85a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for (arguably misformed) package metadata to have the empty string as the namespace. This can happen for example when ingesting an OCI image that does not have the correct repository URL specified.
Currently guac-visualiser does not let you pick beyond a namespace that is the empty string: it would not make the "package name" dropdown sensitive (although it would correctly populate the options from the GraphQL response).
This commit updates the "empty" state for the package name option from the empty string to null (like is used for version). Then update the
disabledparam to be determined on whether the namespace is null (rather than the empty string).