Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add intersection operator, &, to ShapeList #360

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

MatthiasJ1
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (45e0433) 95.79% compared to head (733b814) 95.79%.
Report is 2 commits behind head on dev.

❗ Current head 733b814 differs from pull request most recent head a76e61f. Consider uploading reports for the commit a76e61f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #360   +/-   ##
=======================================
  Coverage   95.79%   95.79%           
=======================================
  Files          23       23           
  Lines        7132     7140    +8     
=======================================
+ Hits         6832     6840    +8     
  Misses        300      300           
Files Coverage Δ
src/build123d/geometry.py 97.84% <100.00%> (ø)
src/build123d/joints.py 100.00% <ø> (ø)
src/build123d/topology.py 95.19% <89.47%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gumyr
Copy link
Owner

gumyr commented Nov 1, 2023

Looks good but would you add a test for this feature?

@MatthiasJ1 MatthiasJ1 force-pushed the shapelist_intersection branch from 733b814 to a76e61f Compare November 2, 2023 18:58
@MatthiasJ1
Copy link
Contributor Author

Done. Also added an equality operator for the test.

@gumyr gumyr merged commit b546986 into gumyr:dev Nov 2, 2023
10 checks passed
@gumyr
Copy link
Owner

gumyr commented Nov 2, 2023

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants