Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed a bug in
ocpsvg
regarding shapes declared as filled in an SVG document but that cannot be imported as faces, for example a single line segment. That included a better method to retrieve the correct color based on the imported OCP shape type.This PR changes the SVG importer to use the new
color_for(shape)
method.The behavior should be functionally identical except for aforementioned degenerate cases. I mostly want to push this change so
build123d
doesn't break when I deprecate the previously usedcolor
property fromocpsvg
.