Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-lint topology.py, joints.py, and operations_part.py #387

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

fischman
Copy link
Contributor

@fischman fischman commented Nov 15, 2023

Reduces pylint findings count from 94 to 52.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (49c0a60) 95.85% compared to head (8f6c11e) 95.85%.

Files Patch % Lines
src/build123d/topology.py 40.00% 3 Missing ⚠️
src/build123d/operations_part.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #387      +/-   ##
==========================================
- Coverage   95.85%   95.85%   -0.01%     
==========================================
  Files          24       24              
  Lines        7245     7244       -1     
==========================================
- Hits         6945     6944       -1     
  Misses        300      300              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/build123d/joints.py Outdated Show resolved Hide resolved
@fischman fischman changed the title De-lint joints.py & operations_part.py De-lint topology.py, joints.py, and operations_part.py Nov 16, 2023
@fischman fischman marked this pull request as draft November 16, 2023 20:08
src/build123d/joints.py Outdated Show resolved Hide resolved
src/build123d/topology.py Outdated Show resolved Hide resolved
src/build123d/topology.py Outdated Show resolved Hide resolved
@fischman fischman marked this pull request as ready for review November 19, 2023 18:11
@gumyr gumyr merged commit fb6f474 into gumyr:dev Nov 22, 2023
8 of 10 checks passed
@gumyr
Copy link
Owner

gumyr commented Nov 22, 2023

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants