Add vertices support to loft #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into loftvertices
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #397 +/- ##
==========================================
+ Coverage 95.84% 95.89% +0.05%
==========================================
Files 24 24
Lines 7275 7292 +17
==========================================
+ Hits 6973 6993 +20
+ Misses 302 299 -3 ☔ View full report in Codecov by Sentry. |
|
Thank you, this is a nice addition to loft. |
|
This is beautiful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should address issue #270 to add vertex support to loft. This is a good way of creating polygonal shapes such as a rectangular pyramid (using ruled=True) that is not very easy otherwise in build123d.
I also added
Sketchas an acceptable input type, which I believe was a missing feature forloftThe formatter also caught some other whitespace issues elsewhere, hopefully that is OK.