Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trapezoid width is now fully controlled by width param #430

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

jdegenstein
Copy link
Collaborator

Should address #380

zz = Trapezoid(10,10,70)
print(zz.bounding_box().size)

zz2 = Trapezoid(10,10,90)
print(zz2.bounding_box().size)

zz3 = Trapezoid(10,10,110)
print(zz3.bounding_box().size)

zz4 = Trapezoid(10,10,110,90)
print(zz4.bounding_box().size)

zz5 = Trapezoid(10,10,90,110)
print(zz5.bounding_box().size)

returns:

Vector: (10.0, 10.0, 0.0)
Vector: (10.0, 10.0, 0.0)
Vector: (10.0, 10.0, 0.0)
Vector: (10.0, 10.0, 0.0)
Vector: (10.0, 10.0, 0.0)

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b2eb1fb) 96.03% compared to head (c75e8d3) 96.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #430   +/-   ##
=======================================
  Coverage   96.03%   96.04%           
=======================================
  Files          24       24           
  Lines        7413     7425   +12     
=======================================
+ Hits         7119     7131   +12     
  Misses        294      294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gumyr gumyr merged commit 203ad9b into gumyr:dev Dec 11, 2023
12 checks passed
@gumyr
Copy link
Owner

gumyr commented Dec 11, 2023

Now is the time to make breaking changes. After we get to v1.0.0 we'll need to put more process into this to give folks a heads up. Hopefully there aren't too many changes like this to come.

@jdegenstein jdegenstein deleted the trapezoid_width branch January 31, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants