fillet/chamfer float comparison with zero via isclose abs_tol=1e-14 #515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failing test on apple silicon. Closes issue #478
This fixes the following previously failing test:
As suspected, the behavior of floats on apple silicon is just a bit different. Comparison of a float with 0.0 is a possible source of architecture specific issues. Current recommendation adopted here is to use
math.isclose
with an appropriateabs_tol
e.g.1e-14
.