Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow cleanup #821

Merged
merged 5 commits into from
Dec 17, 2024
Merged

Workflow cleanup #821

merged 5 commits into from
Dec 17, 2024

Conversation

jdegenstein
Copy link
Collaborator

coverage.yml was not set up the same way as other workflows, this PR fixes that and deletes the now unnecessary requirements.txt file by moving the pytest-cov installation elsewhere.

@jdegenstein jdegenstein marked this pull request as ready for review December 17, 2024 17:56
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.09%. Comparing base (dba9831) to head (fd5515d).
Report is 15 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #821   +/-   ##
=======================================
  Coverage   96.08%   96.09%           
=======================================
  Files          25       24    -1     
  Lines        8499     8493    -6     
=======================================
- Hits         8166     8161    -5     
+ Misses        333      332    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdegenstein
Copy link
Collaborator Author

In the process of fixing one issue, I discovered that .github/actions/setup/action.yml was not setup correctly to accept the input python version. I also fixed that issue and now everything is working as expected.

@jdegenstein jdegenstein merged commit c0728e0 into gumyr:dev Dec 17, 2024
14 checks passed
@jdegenstein jdegenstein deleted the workflow_cleanup branch December 17, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant