Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VDS Combiner code conflicts with documentation #14781

Open
MattWellie opened this issue Jan 10, 2025 · 0 comments · May be fixed by #14784
Open

VDS Combiner code conflicts with documentation #14781

MattWellie opened this issue Jan 10, 2025 · 0 comments · May be fixed by #14784
Assignees

Comments

@MattWellie
Copy link

for start in range(0, len(vcfs), step):

In the documentation:

branch_factor – The number of Variant Datasets to combine at once.
gvcf_batch_size – The number of GVCFs to combine into a Variant Dataset at once.

In this line the number of gVCFs being merged into each vds is step, and the value of step is self.branch_factor, when it should be gvcf_batch_size.

First spotted by @patrick-schultz (https://hail.zulipchat.com/#narrow/channel/123010-Hail-Query-0.2E2-support/topic/gVCF.20Combiner.20Save.20Path.2FPlan/near/492731854)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants