Refine combiner usage #1097
Merged
Refine combiner usage #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1097 +/- ##
=======================================
Coverage 26.72% 26.72%
=======================================
Files 9 9
Lines 1729 1729
=======================================
Hits 462 462
Misses 1267 1267 ☔ View full report in Codecov by Sentry. |
cassimons
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://hail.zulipchat.com/#narrow/channel/123010-Hail-Query-0.2E2-support/topic/gVCF.20Combiner.20Save.20Path.2FPlan: A partial combiner run can only be resumed when the first step completes (gVCF -> VDS)
We're having issues reaching that point. See also hail-is/hail#14781 - the parameters do not currently work as they should.
This change gives us granularity to change any of the combiner attributes relating to the degree of parallelisation of work at each stage