Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[query] Move LoweredTableReaderCoercer into ExecuteContext #14696

Open
wants to merge 1 commit into
base: ehigham/ctx-persisted-ir
Choose a base branch
from
Open

[query] Move LoweredTableReaderCoercer into ExecuteContext #14696

wants to merge 1 commit into from

Conversation

ehigham
Copy link
Member

@ehigham ehigham commented Sep 20, 2024 •
edited
Loading

Refactored table reader coercion and caching mechanism.

What changed?

  • Removed shouldCacheQueryInfo method from Backend class
  • Introduced CoercerCache in ExecuteContext
  • Refactored LoweredTableReader.makeCoercer to return a function instead of a class
  • Removed local caching in GenericTableValue and LoweredTableReader
  • Added NoCaching utility

Why make this change?

This change aims to optimize table reader coercion by:

  • Centralizing caching logic in ExecuteContext
  • Allowing more flexible caching strategies across different backend implementations

@ehigham ehigham marked this pull request as ready for review September 20, 2024 00:03
This was referenced Sep 20, 2024
Merged
Merged
Open
Open
Open
Open
@ehigham Graphite App
Copy link
Member Author

ehigham commented Sep 20, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Sep 20, 2024
Open
Open
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from f2c39a6 to 2f3f122 Compare October 1, 2024 19:45
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 16d54bd to 82cd91b Compare October 1, 2024 19:45
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 2f3f122 to b02c83b Compare October 1, 2024 20:03
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 82cd91b to 63191ba Compare October 1, 2024 20:03
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from b02c83b to 20e6520 Compare October 8, 2024 19:19
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 63191ba to dded098 Compare October 8, 2024 19:19
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 20e6520 to e66b858 Compare October 8, 2024 20:30
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from dded098 to 4f3a6e3 Compare October 8, 2024 20:30
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from e66b858 to 49bdf73 Compare October 16, 2024 20:02
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 4f3a6e3 to db7595e Compare October 16, 2024 20:02
@ehigham ehigham mentioned this pull request Oct 16, 2024
Open
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 49bdf73 to 0ce4a09 Compare October 16, 2024 21:30
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from db7595e to 9615ece Compare October 16, 2024 21:30
@ehigham ehigham mentioned this pull request Oct 17, 2024
Closed
1 task
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 0ce4a09 to 3a671ee Compare October 17, 2024 15:00
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 9615ece to 1951717 Compare October 17, 2024 15:00
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 3a671ee to ee01140 Compare October 21, 2024 15:24
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 1951717 to 3f89fe2 Compare October 21, 2024 15:25
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from ee01140 to 22c3b9b Compare October 21, 2024 18:50
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 3f89fe2 to 1d6e424 Compare October 21, 2024 18:50
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 1408798 to cb9b39e Compare December 12, 2024 22:02
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 045f300 to 5763812 Compare December 12, 2024 22:03
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from cb9b39e to fcf6c67 Compare December 16, 2024 18:49
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 5763812 to 46fbdfc Compare December 16, 2024 18:49
@ehigham ehigham mentioned this pull request Dec 16, 2024
Merged
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from fcf6c67 to fc4afd0 Compare December 17, 2024 16:48
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 46fbdfc to 782730e Compare December 17, 2024 16:48
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from fc4afd0 to 2941b77 Compare December 17, 2024 20:00
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 782730e to 5ac288c Compare December 17, 2024 20:00
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 2941b77 to 25101f4 Compare December 17, 2024 20:29
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 5ac288c to 4c6b7bb Compare December 17, 2024 20:29
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 25101f4 to 5300b18 Compare January 13, 2025 16:36
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 4c6b7bb to b63a366 Compare January 13, 2025 16:36
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 5300b18 to 88a3844 Compare January 17, 2025 21:15
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from b63a366 to 056674c Compare January 17, 2025 21:15
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 88a3844 to 749d5fa Compare January 21, 2025 16:48
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 056674c to 8cf8f24 Compare January 21, 2025 16:48
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 749d5fa to 73eaa93 Compare January 21, 2025 20:15
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 8cf8f24 to 97dcb8a Compare January 21, 2025 20:15
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 73eaa93 to 220a71a Compare January 21, 2025 21:02
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 97dcb8a to 9922a19 Compare January 21, 2025 21:02
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 220a71a to bbbea4f Compare January 22, 2025 15:50
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 9922a19 to cf90a1c Compare January 22, 2025 15:51
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from bbbea4f to db27b14 Compare January 22, 2025 16:46
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from cf90a1c to b9c311f Compare January 22, 2025 16:46
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from db27b14 to 3eae5a8 Compare January 22, 2025 17:30
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from b9c311f to 4c724ba Compare January 22, 2025 17:30
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 4c724ba to df36f36 Compare January 22, 2025 21:13
@ehigham ehigham changed the base branch from ehigham/http-like-rpc to ehigham/ctx-persisted-ir January 22, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ehigham