Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Halide version to 11.0.0 #5296

Closed
wants to merge 1 commit into from
Closed

Set Halide version to 11.0.0 #5296

wants to merge 1 commit into from

Conversation

steven-johnson
Copy link
Contributor

I just took the liberty of creating release/11.x as a clone of release/10.x (as of fa9d6e1). This just updates the version in this branch.

@abadams
Copy link
Member

abadams commented Sep 23, 2020

Why based on 10.x instead of master? (I think the significant difference is how long it takes until we get nested vectorization into a release)

@steven-johnson
Copy link
Contributor Author

Why based on 10.x instead of master?

Ah, I misunderstood the offline discussion earlier. My assumption here was that since Halide10 and Halide11 will be (temporally) very very close in time, it makes sense to keep them in parity in terms of features and bugfixes. There's no reason we have to do it this way, of course, but if I was a downstream user, I'd be a little puzzled if they came out within a couple weeks of each other, but one had more features. (Unless of course the nested vectorization relies on LLVM 11+).

That said, not sure I have super-strong feelings about it. If consensus is to scrap this and re-create the branch from current master (with ~one extra feature) then that's fine with me.

(Note that LLVM 11rc3 was just released yesterday, and is expected to be the 'final' 11.0 version of LLVM.)

@abadams
Copy link
Member

abadams commented Sep 23, 2020

I don't want to needlessly delay getting nested vectorization out there, but I also don't want to backport new features as a general rule. I don't think there's any issue with having a release with only one extra feature. I also don't feel that strongly about it though.

@steven-johnson
Copy link
Contributor Author

I don't want to needlessly delay getting nested vectorization out there, but I also don't want to backport new features as a general rule. I don't think there's any issue with having a release with only one extra feature. I also don't feel that strongly about it though.

@steven-johnson
Copy link
Contributor Author

Yeah, let's abandon this and redo from master soon -- e.g., #5283 should also end up in H11 (since we support wasm in llvm11).

@steven-johnson steven-johnson deleted the srj/r11 branch September 23, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants