Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply version constraints to iOS objects #8546

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Apply version constraints to iOS objects #8546

merged 1 commit into from
Jan 12, 2025

Conversation

alexreinking
Copy link
Member

Fixes linker errors of the form

ld: warning: no platform load command found in 'library.a[2](object.o)', assuming: iOS

If 17 is too restrictive, we can always drop it to be more permissive later.

@alexreinking alexreinking added backport me This change should be backported to release versions release_notes For changes that may warrant a note in README for official releases. labels Jan 7, 2025
@jiawen
Copy link
Contributor

jiawen commented Jan 7, 2025

Thanks Alex! I guess I'll wait for Halide 20 (or maybe 19.x if gets backported?)

@alexreinking alexreinking merged commit 5f56f68 into main Jan 12, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven-johnson steven-johnson steven-johnson approved these changes

Assignees
No one assigned
Labels
backport me This change should be backported to release versions release_notes For changes that may warrant a note in README for official releases.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexreinking @jiawen @steven-johnson