Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin dependency express to 2.5.11 [SECURITY] #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Feb 28, 2024

This PR contains the following updates:

Package Type Update Change
express (source) dependencies pin ~2.5.9 -> 2.5.11

GitHub Vulnerability Alerts

CVE-2014-6393

Vulnerable versions of express do not specify a charset field in the content-type header while displaying 400 level response messages. The lack of enforcing user's browser to set correct charset, could be leveraged by an attacker to perform a cross-site scripting attack, using non-standard encodings, like UTF-7.

Recommendation

For express 3.x, update express to version 3.11 or later.
For express 4.x, update express to version 4.5 or later.

CVE-2024-29041

Impact

Versions of Express.js prior to 4.19.2 and pre-release alpha and beta versions before 5.0.0-beta.3 are affected by an open redirect vulnerability using malformed URLs.

When a user of Express performs a redirect using a user-provided URL Express performs an encode using encodeurl on the contents before passing it to the location header. This can cause malformed URLs to be evaluated in unexpected ways by common redirect allow list implementations in Express applications, leading to an Open Redirect via bypass of a properly implemented allow list.

The main method impacted is res.location() but this is also called from within res.redirect().

Patches

expressjs/express@0867302
expressjs/express@0b74695

An initial fix went out with [email protected], we then patched a feature regression in 4.19.1 and added improved handling for the bypass in 4.19.2.

Workarounds

The fix for this involves pre-parsing the url string with either require('node:url').parse or new URL. These are steps you can take on your own before passing the user input string to res.location or res.redirect.

References

https://github.com/expressjs/express/pull/5539
https://github.com/koajs/koa/issues/1800
https://expressjs.com/en/4x/api.html#res.location

CVE-2024-43796

Impact

In express <4.20.0, passing untrusted user input - even after sanitizing it - to response.redirect() may execute untrusted code

Patches

this issue is patched in express 4.20.0

Workarounds

users are encouraged to upgrade to the patched version of express, but otherwise can workaround this issue by making sure any untrusted inputs are safe, ideally by validating them against an explicit allowlist

Details

successful exploitation of this vector requires the following:

  1. The attacker MUST control the input to response.redirect()
  2. express MUST NOT redirect before the template appears
  3. the browser MUST NOT complete redirection before:
  4. the user MUST click on the link in the template

CVE-2024-10491

A vulnerability has been identified in the Express response.links function, allowing for arbitrary resource injection in the Link header when unsanitized data is used.

The issue arises from improper sanitization in Link header values, which can allow a combination of characters like ,, ;, and <> to preload malicious resources.

This vulnerability is especially relevant for dynamic parameters.

Add the preset :preserveSemverRanges to your config if you don't want to pin your dependencies.


Configuration

📅 Schedule: Branch creation - "" in timezone America/Vancouver, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 4 times, most recently from b36dcfe to 2149f76 Compare March 1, 2024 08:47
@renovate renovate bot changed the title Pin dependency express to 2.5.11 [SECURITY] Update dependency express to v3 [SECURITY] Mar 1, 2024
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 2149f76 to 987cfa3 Compare March 13, 2024 02:56
@renovate renovate bot changed the title Update dependency express to v3 [SECURITY] Pin dependency express to 2.5.11 [SECURITY] Mar 13, 2024
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 987cfa3 to 7dc54da Compare March 16, 2024 05:35
@renovate renovate bot changed the title Pin dependency express to 2.5.11 [SECURITY] Update dependency express to v3 [SECURITY] Mar 16, 2024
@renovate renovate bot changed the title Update dependency express to v3 [SECURITY] Pin dependency express to 2.5.11 [SECURITY] Mar 21, 2024
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 2 times, most recently from ee7d9f8 to 3918934 Compare March 23, 2024 08:51
@renovate renovate bot changed the title Pin dependency express to 2.5.11 [SECURITY] Update dependency express to v3 [SECURITY] Mar 23, 2024
@renovate renovate bot changed the title Update dependency express to v3 [SECURITY] Pin dependency express to 2.5.11 [SECURITY] Mar 25, 2024
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 2 times, most recently from acc1ee6 to fee9247 Compare March 27, 2024 23:49
@renovate renovate bot changed the title Pin dependency express to 2.5.11 [SECURITY] Update dependency express to v3 [SECURITY] Mar 27, 2024
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from fee9247 to 056aab6 Compare March 31, 2024 02:55
@renovate renovate bot changed the title Update dependency express to v3 [SECURITY] Update dependency express to v4 [SECURITY] Mar 31, 2024
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 056aab6 to 9497821 Compare April 14, 2024 23:44
@renovate renovate bot changed the title Update dependency express to v4 [SECURITY] Pin dependency express to 2.5.11 [SECURITY] Apr 14, 2024
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 9497821 to 9e0ce14 Compare April 16, 2024 23:51
@renovate renovate bot changed the title Pin dependency express to 2.5.11 [SECURITY] Update dependency express to v4 [SECURITY] Apr 16, 2024
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 9e0ce14 to e9ae2c1 Compare April 23, 2024 02:40
@renovate renovate bot changed the title Update dependency express to v4 [SECURITY] Pin dependency express to 2.5.11 [SECURITY] Apr 23, 2024
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from e9ae2c1 to 7f9d2df Compare April 24, 2024 23:23
@renovate renovate bot changed the title Pin dependency express to 2.5.11 [SECURITY] Update dependency express to v4 [SECURITY] Apr 24, 2024
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 7f9d2df to 9f127e0 Compare April 27, 2024 08:52
@renovate renovate bot changed the title Update dependency express to v4 [SECURITY] Pin dependency express to 2.5.11 [SECURITY] Apr 27, 2024
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 9f127e0 to 2543d91 Compare April 28, 2024 11:57
@renovate renovate bot changed the title Update dependency express to v4 [SECURITY] Pin dependency express to 2.5.11 [SECURITY] Oct 10, 2024
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 4e0d235 to e2eea3b Compare October 13, 2024 10:39
@renovate renovate bot changed the title Pin dependency express to 2.5.11 [SECURITY] Update dependency express to v4 [SECURITY] Oct 13, 2024
@renovate renovate bot changed the title Update dependency express to v4 [SECURITY] Pin dependency express to 2.5.11 [SECURITY] Oct 20, 2024
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 2 times, most recently from 7beee71 to 6f9902e Compare October 21, 2024 05:01
@renovate renovate bot changed the title Pin dependency express to 2.5.11 [SECURITY] Update dependency express to v4 [SECURITY] Oct 21, 2024
@renovate renovate bot changed the title Update dependency express to v4 [SECURITY] Pin dependency express to 2.5.11 [SECURITY] Oct 30, 2024
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 2 times, most recently from 0b1e368 to 4283398 Compare November 1, 2024 05:16
@renovate renovate bot changed the title Pin dependency express to 2.5.11 [SECURITY] Update dependency express to v4 [SECURITY] Nov 1, 2024
@renovate renovate bot changed the title Update dependency express to v4 [SECURITY] Pin dependency express to 2.5.11 [SECURITY] Dec 5, 2024
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 2 times, most recently from a9e5a5f to d5e21e9 Compare December 7, 2024 02:35
@renovate renovate bot changed the title Pin dependency express to 2.5.11 [SECURITY] Update dependency express to v4 [SECURITY] Dec 7, 2024
@renovate renovate bot changed the title Update dependency express to v4 [SECURITY] Pin dependency express to 2.5.11 [SECURITY] Dec 21, 2024
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 2 times, most recently from d7d8bb2 to b36ea28 Compare December 23, 2024 14:54
@renovate renovate bot changed the title Pin dependency express to 2.5.11 [SECURITY] Update dependency express to v4 [SECURITY] Dec 23, 2024
@renovate renovate bot changed the title Update dependency express to v4 [SECURITY] Pin dependency express to 2.5.11 [SECURITY] Jan 2, 2025
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 2 times, most recently from 1ea1b49 to cd4cb7a Compare January 3, 2025 02:23
@renovate renovate bot changed the title Pin dependency express to 2.5.11 [SECURITY] Update dependency express to v4 [SECURITY] Jan 3, 2025
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from cd4cb7a to 58b8152 Compare January 15, 2025 03:58
@renovate renovate bot changed the title Update dependency express to v4 [SECURITY] Pin dependency express to 2.5.11 [SECURITY] Jan 15, 2025
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 58b8152 to ba8231f Compare January 17, 2025 19:16
@renovate renovate bot changed the title Pin dependency express to 2.5.11 [SECURITY] Update dependency express to v4 [SECURITY] Jan 17, 2025
@renovate renovate bot changed the title Update dependency express to v4 [SECURITY] Pin dependency express to 2.5.11 [SECURITY] Jan 24, 2025
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from ba8231f to a3affd5 Compare January 24, 2025 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants