Add codepoints_iter() methods for cmap Subtable4/Subtable12 #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows early exit unlike `codepoints()`. Signed-off-by: Mohammad AlSaleh <[email protected]>
|
Not really a draft. But only needed if a change in another crate (PR incoming) is accepted. |
Signed-off-by: Mohammad AlSaleh <[email protected]>
alerque
requested changes
Nov 29, 2024
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "ttf-parser" | |||
| version = "0.24.1" | |||
| version = "0.25.0" | |||
There was a problem hiding this comment.
Please don't change the version number in PRs. Just the other changes will do and we can set the version as appropriate during the release process.
| f(code_point); | ||
| } | ||
| } | ||
| pub fn codepoints(&self, f: impl FnMut(u32)) { |
There was a problem hiding this comment.
This function name doesn't seam clear to me. Wouldn't something with "map" or "for_each" in the name be more explanatory?
There was a problem hiding this comment.
Is the question directed at me?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows early exit unlike
codepoints().