fix: Update slack action usage for slack action v2 #3802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutahhir
requested review from
ansgarm and
DanielMSchmidt
and removed request for
a team
DanielMSchmidt
approved these changes
Jan 14, 2025
Base automatically changed from
tsccr-auto-pinning/trusted/2024-12-30
to
main
January 21, 2025 09:11
mutahhir
force-pushed
the
fix/slack-actions-update
branch
from
376b8a8 to
9805823
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The parent PR updates the Slack Github Action to v2 which has a few breaking changes that affect us. Information on breaking changes are here.
The actions pertain to failure reports in our #feed-terraform-cdk channel. From investigating the integration settings, it seems like all are webhooks are of the 'workflow builder' type. For those, we have to set the
webhook-typetowebhook-trigger. NOTE: If any of our webhooks are not of that type and I was mistaken, please let me know so I can update the PR accordingly.This PR is based on top of the parent PR's branch, so should be merged right after the parent. I'll merge that one right after this PR is approved.
Checklist