Skip to content

Commit

Permalink
Remove test-membership duplication (#930)
Browse files Browse the repository at this point in the history
The PR builder uses a local copy of an action which has [since been
centralised](https://github.com/hazelcast/hazelcast-tpm/blob/main/membership/action.yaml).

This was originally copied from the pattern in `hazelcast-nodejs-client`
- but this has [since been
migrated](https://github.com/hazelcast/hazelcast-nodejs-client/blob/master/.github/workflows/coverage_runner.yml#L16-L29).

Updated to use centralise version - allowing a central place to make
improvements.
  • Loading branch information
JackPGreen authored Dec 9, 2024
1 parent 21bec8c commit c6d9645
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 44 deletions.
33 changes: 0 additions & 33 deletions .github/actions/test-membership/action.yml

This file was deleted.

13 changes: 2 additions & 11 deletions .github/workflows/build-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,21 +39,12 @@ jobs:
name: Test Hazelcast Membership
runs-on: ubuntu-latest
outputs:
is-hazelcast: ${{ steps.test-membership.outputs.is-member }}
is-hazelcast: ${{ steps.test-membership.outputs.check-result }}

steps:
# checkout the hazelcast/hazelcast-csharp-client repository
# bare minimum - just to use actions
- name: Checkout code
uses: actions/checkout@v4
with:
ref: ${{ inputs.ref }}
token: ${{ secrets.GITHUB_TOKEN }}
submodules: false

- name: Test
id: test-membership
uses: ./.github/actions/test-membership
uses: hazelcast/hazelcast-tpm/membership@main
with:
organization-name: hazelcast
member-name: ${{ github.event.pull_request.head.repo.owner.login }}
Expand Down

0 comments on commit c6d9645

Please sign in to comment.