[API-2196] Add a note about naming of the terminated/onClose event in Reliable Topic #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for silly-valkyrie-e996d9 failed.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #869 +/- ##
==========================================
- Coverage 85.00% 84.85% -0.15%
==========================================
Files 914 914
Lines 21618 21618
==========================================
- Hits 18376 18345 -31
- Misses 3242 3273 +31 ☔ View full report in Codecov by Sentry. |
ihsandemir
reviewed
Jan 10, 2024
Co-authored-by: ihsan demir <[email protected]>
ihsandemir
approved these changes
Jan 12, 2024
zpqrtbnk
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OnCloseevent is already supported in .Net client asTerminatedfrom dayReliableTopicis implemented. Due to different naming between Hazelcast clients, I've added a note to the docs.