Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API-2160] Add Nullable Support for Value Types on SQL Queries #872

Merged
merged 5 commits into from
Jan 26, 2024

Conversation

emreyigit
Copy link
Collaborator

@emreyigit emreyigit commented Jan 19, 2024

If result of a SQL query contains null values, .Net client throws. See #854 for more details. This is because although SQL supports null for primitive types. The client cannot handle it. I've added nullable support for fixed sized type which are primitive ones.

Also, current implementation were failing while parsing null or mixed result due to wrong assumptions on List. Defining a size during initialization, does not mean that the list created with null values. This is fixed in the PR.

@emreyigit emreyigit added the Type: Defect Issue is a Defect ie a Bug that needs to be fixed. label Jan 19, 2024
@emreyigit emreyigit added this to the 5.4.0 milestone Jan 19, 2024
@emreyigit emreyigit requested a review from zpqrtbnk January 19, 2024 10:35
Copy link

netlify bot commented Jan 19, 2024

Deploy Preview for silly-valkyrie-e996d9 failed.

Name Link
🔨 Latest commit e6784f7
🔍 Latest deploy log https://app.netlify.com/sites/silly-valkyrie-e996d9/deploys/65b258de6942930008077fad

@emreyigit emreyigit self-assigned this Jan 19, 2024
@emreyigit emreyigit linked an issue Jan 19, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

Attention: 1060 lines in your changes are missing coverage. Please review.

Comparison is base (7c75b2e) 84.87% compared to head (e6784f7) 80.76%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/Hazelcast.Net/Models/MapOptions.cs 31.69% 125 Missing ⚠️
src/Hazelcast.Net/Models/QueryCacheOptions.cs 34.83% 58 Missing ⚠️
src/Hazelcast.Net/Models/MapStoreOptions.cs 33.82% 45 Missing ⚠️
src/Hazelcast.Net/Models/RingbufferOptions.cs 35.71% 45 Missing ⚠️
...rotocol/Codecs/DynamicConfigAddCacheConfigCodec.cs 0.00% 40 Missing ⚠️
...cast.Net/Models/CacheSimpleEntryListenerOptions.cs 0.00% 29 Missing ⚠️
src/Hazelcast.Net/Models/Capacity.cs 10.00% 27 Missing ⚠️
src/Hazelcast.Net/Models/WanReplicationRef.cs 31.57% 26 Missing ⚠️
src/Hazelcast.Net/Models/RingbufferStoreOptions.cs 31.42% 24 Missing ⚠️
src/Hazelcast.Net/NearCaching/NearCacheOptions.cs 67.60% 23 Missing ⚠️
... and 42 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #872      +/-   ##
==========================================
- Coverage   84.87%   80.76%   -4.12%     
==========================================
  Files         941     1018      +77     
  Lines       22346    24496    +2150     
==========================================
+ Hits        18966    19783     +817     
- Misses       3380     4713    +1333     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zpqrtbnk zpqrtbnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@emreyigit emreyigit merged commit 19642e1 into hazelcast:master Jan 26, 2024
16 of 20 checks passed
@emreyigit emreyigit deleted the issue-854-nullcheck branch July 4, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Defect Issue is a Defect ie a Bug that needs to be fixed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error executing SQL query using IN operator [API-2160]
3 participants