Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for barrel files and extensionless imports. This can be… #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jay-herrera
Copy link

… slow since we have to search through each exported file in the barrel file

… slow since we have to search through each exported file in the barrel file
Copy link

swimm-io bot commented Mar 31, 2024

Create a document from this PR?

If this PR introduces a new feature or an interesting change, turn it into a document.

Turn it into a doc automatically with AI, or start a doc manually with all the changes from this PR.

Document with AI  Create draft from PR

Configure these notifications in the repo settings (admins only)


Don't have access to Swimm yet? Click here to create your account and join this workspace.

@hb1998 hb1998 self-requested a review April 1, 2024 13:38
@hb1998
Copy link
Owner

hb1998 commented Apr 1, 2024

@jay-herrera can you give me a sample imports to test this or can you tell me if this is fine ?

export * from './foo'; 
export * from './bar'; 

we also need to add unit tests for this.
thanks for the pr, let me go through the approach once

@jay-herrera
Copy link
Author

Hey, Habeeb! Those imports shoiuld work perfectly

@jay-herrera
Copy link
Author

jay-herrera commented Apr 2, 2024

Also added support for destructured props and default exports. For now, all of these features will only work with functional components. I've tested it experimentally, but I can write unit tests when I get a chance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants