-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make action compatible with node 20 #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/hellofresh/action-compile-job-status/blob/master/action.yml#L20
needs to be changed to:
runs:
using: 'node20'
main: dist/index.js
I'm still a bit buffled why this fixes: https://github.com/hellofresh/hf-kubernetes/actions/runs/8617884630/job/23618966950 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you update the dist?
It's a bit strange that the overall lines added is quite big. Looks like tree-shaking might be missing?
Could we add the compilation to the workflows like that.
so it automatically updates in PRs and is documented that way, too.
From local, I ran the steps defined at the workflow in repository: npm ci
npm run package I created #11 to track this.
We use @vercel/ncc to create the dist script. Unfortunately, it does not support tree-shaking. We could try a different bundler (like rollup) that supports tree-shaking to make the dist package smaller (tracked in #12). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, nothing more to complain about.
Lets give it a try
Update dependencies and test actions in preparation for a new release compatible with node 20.