Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow optional timeout message for timing.wait #800

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Allow optional timeout message for timing.wait #800

merged 2 commits into from
Jan 21, 2025

Conversation

hwikle-lanl
Copy link
Collaborator

Code review checklist:

  • Code is generally sensical and well commented
  • Variable/function names all telegraph their purpose and contents
  • Functions/classes have useful doc strings
  • Function arguments are typed
  • Added/modified unit tests to cover changes.
  • New features have documentation added to the docs.
  • New features and backwards compatibility breaks are noted in the RELEASE.md

@hwikle-lanl hwikle-lanl self-assigned this Jan 21, 2025
@hwikle-lanl
Short (50 chars or less) summary of changes
3d8e425 
This commit fixes an issue that occurs when parsing dates where
relative times result in negative month values getting passed to
the safe_update function. It may be a good idea to add a few
more unit tests, which I will do as I have time.
@hwikle-lanl
Allow optional timeout message for timing.wait
11b6e77
@hwikle-lanl hwikle-lanl force-pushed the wait-optional-message branch from 3876b25 to 11b6e77 Compare January 21, 2025 16:34
@hwikle-lanl hwikle-lanl merged commit 14a9731 into develop Jan 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hwikle-lanl hwikle-lanl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hwikle-lanl