Improve BLOCKHASH Short Circuit #8171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve efficiency of the blockhash range checking by only testing the soughtBlock. Signed-off-by: Danno Ferrin <[email protected]>
garyschulte
reviewed
Jan 24, 2025
Comment on lines
60
to
62
| // If the current block is the genesis block or the sought block is | ||
| // not within the lookback window, zero is returned. | ||
| if (currentBlockNumber == 0 | ||
| if (soughtBlock < 0 |
There was a problem hiding this comment.
the comment for this condition is no longer accurate
garyschulte
approved these changes
Jan 24, 2025
Signed-off-by: Danno Ferrin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Improve efficiency of the blockhash range checking by only testing the soughtBlock.
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests