-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My availability tab #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into my-availability-tab
Closed
5 tasks
@MinhxNguyen7 Marking this PR as ready to review. The availability page is also live on staging. |
MinhxNguyen7
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good. Let's push this, then you can address these suggestions:
- The margins for the availability on mobile are pretty big. I think that if we put the arrows, we'd be able to fit one more day.
- Can you make the page/number of columns responsive to screen size? You started with mobile, which is good.
A few more things that you can leave for later if there are better things to do:
- Mobile selection works perfectly, but, on desktop, if you drag outside of the grid, it doesn't register the mouse up.
- Instead of manipulating ZotDate arrays and the such, there should be a class that encapsulates this logic. Not sure how feasible this is, but what we're doing is somewhat error-prone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Drag-selecting multiple date availabilities:
Confirmation of date availabilities (mouse up/touch end):
Pagination maintains availability across multiple pages
Availability state is stored in svelte store (maintained when tab is switched)
Other changes:
Closes #7.