Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My availability tab #20

Merged
merged 28 commits into from
Jan 30, 2024
Merged

My availability tab #20

merged 28 commits into from
Jan 30, 2024

Conversation

seancfong
Copy link
Member

@seancfong seancfong commented Jan 25, 2024

Summary

Drag-selecting multiple date availabilities:
image

Confirmation of date availabilities (mouse up/touch end):
image

Pagination maintains availability across multiple pages
pagination

Availability state is stored in svelte store (maintained when tab is switched)
tab store

  • Clicking on cells to toggle their availability
  • Have a separate store for the availability so that other pages can access it
  • Drag over cells to change the availability
  • Reasonable proportions
  • Looks nice (imo)

Other changes:

  • Added ZotDate class for consistent date format
  • Converted Calendar to use ZotDate objects

Closes #7.

@seancfong seancfong linked an issue Jan 25, 2024 that may be closed by this pull request
5 tasks
@seancfong seancfong temporarily deployed to staging-20 January 25, 2024 23:43 — with GitHub Actions Inactive
@seancfong seancfong temporarily deployed to staging-20 January 25, 2024 23:48 — with GitHub Actions Inactive
@seancfong seancfong temporarily deployed to staging-20 January 25, 2024 23:52 — with GitHub Actions Inactive
@seancfong seancfong temporarily deployed to staging-20 January 26, 2024 04:44 — with GitHub Actions Inactive
@seancfong seancfong temporarily deployed to staging-20 January 26, 2024 06:22 — with GitHub Actions Inactive
@seancfong seancfong temporarily deployed to staging-20 January 26, 2024 23:38 — with GitHub Actions Inactive
@seancfong seancfong temporarily deployed to staging-20 January 28, 2024 09:54 — with GitHub Actions Inactive
@seancfong seancfong temporarily deployed to staging-20 January 28, 2024 11:48 — with GitHub Actions Inactive
@seancfong seancfong temporarily deployed to staging-20 January 28, 2024 12:01 — with GitHub Actions Inactive
@seancfong seancfong temporarily deployed to staging-20 January 28, 2024 12:07 — with GitHub Actions Inactive
@seancfong seancfong marked this pull request as ready for review January 28, 2024 12:47
@seancfong seancfong self-assigned this Jan 28, 2024
@seancfong
Copy link
Member Author

@MinhxNguyen7 Marking this PR as ready to review. The availability page is also live on staging.

Copy link
Member

@MinhxNguyen7 MinhxNguyen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. Let's push this, then you can address these suggestions:

  • The margins for the availability on mobile are pretty big. I think that if we put the arrows, we'd be able to fit one more day.
  • Can you make the page/number of columns responsive to screen size? You started with mobile, which is good.

A few more things that you can leave for later if there are better things to do:

  • Mobile selection works perfectly, but, on desktop, if you drag outside of the grid, it doesn't register the mouse up.
  • Instead of manipulating ZotDate arrays and the such, there should be a class that encapsulates this logic. Not sure how feasible this is, but what we're doing is somewhat error-prone.

@MinhxNguyen7 MinhxNguyen7 merged commit 3c5d07d into main Jan 30, 2024
2 checks passed
@KevinWu098 KevinWu098 deleted the my-availability-tab branch October 17, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

My availability tab
3 participants