Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restyle Summary Page #56

Merged
merged 10 commits into from
Mar 7, 2024
Merged

Restyle Summary Page #56

merged 10 commits into from
Mar 7, 2024

Conversation

seancfong
Copy link
Member

@seancfong seancfong commented Feb 22, 2024 •
edited
Loading

Summary

Scheduled meetings

  • Converted Scheduled Meetings to timeline view on mobile and desktop
    image
    image
  • Added option to indicate availability for a meeting once it is scheduled (although buttons have no effect for now)
    image

Unscheduled meetings

  • Added hi-fi design for unscheduled meetings
  • Added indicator for whether a user has set their availability or not
    image

@seancfong seancfong linked an issue Feb 22, 2024 that may be closed by this pull request
Restyle Summary Page #55
Closed
@seancfong seancfong temporarily deployed to staging-56 February 22, 2024 03:15 — with GitHub Actions Inactive
@seancfong seancfong temporarily deployed to staging-56 February 22, 2024 09:55 — with GitHub Actions Inactive
@seancfong seancfong temporarily deployed to staging-56 February 22, 2024 11:14 — with GitHub Actions Inactive
@seancfong seancfong temporarily deployed to staging-56 February 22, 2024 13:16 — with GitHub Actions Inactive
@seancfong seancfong temporarily deployed to staging-56 February 22, 2024 14:05 — with GitHub Actions Inactive
@seancfong seancfong temporarily deployed to staging-56 February 22, 2024 14:25 — with GitHub Actions Inactive
@seancfong seancfong temporarily deployed to staging-56 February 22, 2024 14:28 — with GitHub Actions Inactive
@seancfong seancfong temporarily deployed to staging-56 February 22, 2024 14:33 — with GitHub Actions Inactive
@seancfong seancfong temporarily deployed to staging-56 February 26, 2024 09:14 — with GitHub Actions Inactive
@seancfong seancfong marked this pull request as ready for review February 26, 2024 09:23
@seancfong seancfong temporarily deployed to staging-56 February 27, 2024 11:25 — with GitHub Actions Inactive
@seancfong seancfong requested a review from adi-lux March 7, 2024 07:05
adi-lux
adi-lux approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@adi-lux adi-lux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good. I'm assuming hasIndicated is for whether or not the user has indicated their availability? It feels a little awkward to put "Indicated" in terms of clarity (as to what it means), but it works for now.

@adi-lux adi-lux merged commit 5239cce into main Mar 7, 2024
2 checks passed
@adi-lux adi-lux deleted the 55-restyle-summary-page branch March 7, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adi-lux adi-lux adi-lux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restyle Summary Page
2 participants
@seancfong @adi-lux