Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated HERON submodule for EOY 2020 milestone #1421

Merged
merged 2 commits into from
Jan 30, 2021

Conversation

PaulTalbot-INL
Copy link
Collaborator

@PaulTalbot-INL PaulTalbot-INL commented Jan 26, 2021


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Continues #1114

What are the significant changes in functionality due to this change request?

Updates HERON submodule for EOY 2020 milestone work


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@PaulTalbot-INL PaulTalbot-INL added the RAVENv2.1 All tasks and defects that will go in RAVEN v2.1 label Jan 26, 2021
@PaulTalbot-INL PaulTalbot-INL requested a review from alfoa January 26, 2021 23:30
@moosebuild
Copy link

Job Test mac on c43fc8f : invalidated by @alfoa

@moosebuild
Copy link

Job Test mac on c43fc8f : invalidated by @PaulTalbot-INL

Only mac failed "Failed tests/framework/ensembleModelTests/testEnsembleModelLinearParallelWithOptimizer" with RAY parallelization error; checking repeatability.

@PaulTalbot-INL
Copy link
Collaborator Author

It looks like Failed tests/framework/ensembleModelTests/testEnsembleModelLinearParallelWithOptimizer was a spurious failure that wasn't replicated.

@alfoa
Copy link
Collaborator

alfoa commented Jan 30, 2021

PR approved...

PR can be merged...

Opened an issue in HERON repository to address PIP issue (PIP machine). See idaholab/HERON#66

@alfoa alfoa merged commit 2f6910d into idaholab:devel Jan 30, 2021
@alfoa alfoa deleted the update_heron branch January 30, 2021 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RAVENv2.1 All tasks and defects that will go in RAVEN v2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants