-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump Python to 3.12 #1072
Merged
Merged
bump Python to 3.12 #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Looks like coverage is our problem regarding 3.12, and it turns out 3.12 is even a bit faster than 3.11 with coverage disabled. Interestingly, there have been a few performance-related issues with coverage and 3.12, but all of these seem to hav been resolved in current package versions... |
MTCam
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pytest failures do not seem to be related to:
Although generally slowdowns lead to CI cancelation in
test_operators.py
, testing that file separately seems to work fine (see https://github.com/illinois-ceesd/mirgecom/actions/runs/11484157110/job/31961509540).Something aboutctx_factory
may be fishy - some test files usectx_factory
, someactx_factory
.Perhaps the order in which tests are run is relevant?Or is it coverage testing?
Google sheets