Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump Python to 3.12 #1072

Merged
merged 13 commits into from
Oct 25, 2024
Merged

bump Python to 3.12 #1072

merged 13 commits into from
Oct 25, 2024

Conversation

matthiasdiener
Copy link
Member

@matthiasdiener matthiasdiener commented Oct 14, 2024

The pytest failures do not seem to be related to:

Although generally slowdowns lead to CI cancelation in test_operators.py, testing that file separately seems to work fine (see https://github.com/illinois-ceesd/mirgecom/actions/runs/11484157110/job/31961509540).

Something about ctx_factory may be fishy - some test files use ctx_factory, some actx_factory.

Perhaps the order in which tests are run is relevant?

Or is it coverage testing?

Google sheets

@matthiasdiener matthiasdiener self-assigned this Oct 14, 2024
@matthiasdiener matthiasdiener mentioned this pull request Oct 24, 2024
8 tasks
@matthiasdiener
Copy link
Member Author

matthiasdiener commented Oct 24, 2024

Looks like coverage is our problem regarding 3.12, and it turns out 3.12 is even a bit faster than 3.11 with coverage disabled. Interestingly, there have been a few performance-related issues with coverage and 3.12, but all of these seem to hav been resolved in current package versions...

e.g., python/cpython#119118 , nedbat/coveragepy#1785

@matthiasdiener matthiasdiener requested a review from MTCam October 24, 2024 21:15
@matthiasdiener matthiasdiener marked this pull request as ready for review October 24, 2024 21:15
@matthiasdiener matthiasdiener merged commit 912c589 into main Oct 25, 2024
13 checks passed
@matthiasdiener matthiasdiener deleted the py312 branch October 25, 2024 15:16
MTCam added a commit that referenced this pull request Oct 28, 2024
MTCam added a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants