-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add entropy-stable dg operators #922
Conversation
Updated get_box_mesh function
… and multiphysics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments/questions.
dd=dd_vol, comm_tag=comm_tag, limiter_func=limiter_func, | ||
entropy_stable=use_esdg) | ||
|
||
if use_esdg: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if we should mix esdg_euler
with plain_euler
or simply let the driver/navierstokes operator handle which one to use. I have a preference to keep them separate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will push back on this a bit. We have in excess of 20 examples to change. Adding the necessary constructs to all drivers to do in in the driver-side is an onerous undertaking. On the other hand, letting the driver specify use_esdg=True
and factoring out the rest into this common code reduces the total amount of code required by a lot , makes it easier to read, and much easier to use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Adds ESDG continued from @thomasgibson's previous work. (#573).
The main pieces are:
euler.py
entropy_stable_euler_operator
inviscid.py
-
entropy_conserving_flux_chandrashekar
(single gas only, passive scalars ok)-
entropy_conserving_flux_renac
(supports mixtures)-
entropy_stable_inviscid_facial_flux_rusanov
ESDG Rusanov-type flux with dissipation-
entropy_stable_inviscid_facial_flux
. General ESDG flux, dissipation optionalnavierstokes.py
inviscid_fluid_operator
= {None,euler_operator
,entropy_stable_euler_operator
} for inviscid terms (default is None, meaning - do inline inviscid terms)gas_model.py
CV
<-->EV
(move to EOS?)CV
from projectedEV
Review guide:
pulse-mpi.py
thermally-coupled-mpi.py
Questions for the review: